-
Notifications
You must be signed in to change notification settings - Fork 835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
acert: fix holder entityName parsing. #8166
Conversation
Retest this please. |
Can you please add test cases for: Thanks! |
@philljj Please resolve merge conflicts. |
301c353
to
622fc70
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few minor things.
wolfcrypt/src/asn.c
Outdated
}; | ||
|
||
enum { | ||
HOLDER_IDX_SEQ = 0, | ||
HOLDER_IDX_ISSUERSERIAL_SEQ, | ||
HOLDER_IDX_GN_SEQ, | ||
HOLDER_IDX_SERIAL_INT, | ||
HOLDER_IDX_GN_SEQ_OPT1 | ||
HOLDER_IDX_GN_SEQ_OPT1, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a rebase artifact. Please remove the last trailing ,
. Thanks.
wolfcrypt/src/asn.c
Outdated
|
||
ret = DecodeAcertGeneralNames(gn_input, gn_len, cert, | ||
if (gn_len >= ASN_LONG_LENGTH) { gn_len += 3; } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please expand these lines...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
wolfcrypt/src/asn.c
Outdated
i_issuer = (dataASN[ACERT_IDX_ACINFO_ISSUER_V2].tag != 0) ? | ||
ACERT_IDX_ACINFO_ISSUER_V2 : ACERT_IDX_ACINFO_ISSUER_V1; | ||
|
||
#ifdef WOLFSSL_DEBUG_ASN_TEMPLATE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you intend to leave these?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer to keep these if ok, because some of the example acerts have non-standard holder or issuer fields.
Description
Fixes zd#18889.
Testing
Printing before:
Printing after: