Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMAKE: look for pthreads when importing wolfSSL if required #8162

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

redbaron
Copy link

@redbaron redbaron commented Nov 7, 2024

Description

All required dependencies of a package must also be found in the package configuration file. Consumers of wolfSSL can't know if it was built with or without threads support. This change adds find_package(Threads) lookup in the file used for find_package(wolfssl) if wolfSSL was built with threads support.

Testing

  1. build wolfSSL with threads support
  2. consume wolfSSL in the project with `find_package(wolfssl CONFIG REQUIRED)

Checklist

  • added tests
  • updated/added doxygen
  • updated appropriate READMEs
  • Updated manual and documentation

All required dependencies of a package must also be found in the
package configuration file. Consumers of wolfSSL can't know
if it was built with or without threads support. This change
adds find_package(Threads) lookup in the file used for
find_package(wolfssl) if wolfSSL was built with threads support.
@wolfSSL-Bot
Copy link

Can one of the admins verify this patch?

@embhorn
Copy link
Member

embhorn commented Nov 12, 2024

@redbaron is approved as a wolfSSL contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants