Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit test for framework #3

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add unit test for framework #3

wants to merge 3 commits into from

Conversation

wisererik
Copy link
Owner

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Release note:

@codecov-commenter
Copy link

codecov-commenter commented Jun 6, 2020

Codecov Report

Merging #3 into master will increase coverage by 9.22%.
The diff coverage is 38.57%.

@@            Coverage Diff             @@
##           master       #3      +/-   ##
==========================================
+ Coverage   29.19%   38.42%   +9.22%     
==========================================
  Files          61       61              
  Lines        3919     3977      +58     
  Branches      441      450       +9     
==========================================
+ Hits         1144     1528     +384     
+ Misses       2758     2388     -370     
- Partials       17       61      +44     
Impacted Files Coverage Δ
dolphin/alert_manager/alert_processor.py 0.00% <0.00%> (ø)
dolphin/alert_manager/trap_receiver.py 0.00% <0.00%> (ø)
dolphin/api/common/wsgi.py 23.46% <0.00%> (-0.23%) ⬇️
dolphin/api/extensions.py 0.00% <0.00%> (-22.70%) ⬇️
dolphin/api/v1/access_info.py 0.00% <0.00%> (ø)
dolphin/api/v1/alert.py 0.00% <0.00%> (ø)
dolphin/api/v1/pools.py 0.00% <0.00%> (ø)
dolphin/api/v1/volumes.py 0.00% <0.00%> (ø)
dolphin/api/validation/validators.py 23.43% <0.00%> (-0.60%) ⬇️
dolphin/common/sqlalchemyutils.py 35.29% <0.00%> (+14.70%) ⬆️
... and 31 more

@wisererik wisererik force-pushed the unittest-ci branch 3 times, most recently from 7cb676c to 9120e28 Compare June 8, 2020 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants