Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unlock the screen orientation when exiting fullscreen #206

Merged
merged 4 commits into from
Nov 24, 2022
Merged

Unlock the screen orientation when exiting fullscreen #206

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
74c8b23
Unlock the screen orientation when exiting fullscreen
marcoscaceres Oct 31, 2022
a6076f8
fixup
marcoscaceres Oct 31, 2022
6b76105
fixup
marcoscaceres Oct 31, 2022
07cd6c6
Only fully unlock the screen orientation
marcoscaceres Nov 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 3 additions & 9 deletions fullscreen.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,12 +18,6 @@ spec:infra
type:dfn; text:string
</pre>

<pre class=anchors>
urlPrefix: https://w3c.github.io/screen-orientation/#dfn-
type: dfn
text: triggered by a user generated orientation change
</pre>

marcoscaceres marked this conversation as resolved.
Show resolved Hide resolved
<pre class=biblio>
{
"CSS": {
Expand Down Expand Up @@ -87,7 +81,6 @@ its <a>node document</a>'s <a>top layer</a>.
<li><p><a lt="unfullscreen an element">Unfullscreen elements</a> whose <a>fullscreen flag</a> is
set, within <var>document</var>'s <a>top layer</a>, except for <var>document</var>'s
<a>fullscreen element</a>.

marcoscaceres marked this conversation as resolved.
Show resolved Hide resolved
<li><p><a>Exit fullscreen</a> <var>document</var>.
</ol>
</div>
Expand Down Expand Up @@ -266,8 +259,7 @@ are:

<li><p><a>Fullscreen is supported</a>.

<li><p><a>This</a>'s <a>relevant global object</a> has <a>transient activation</a> or the
algorithm is <a>triggered by a user generated orientation change</a>.
marcoscaceres marked this conversation as resolved.
Show resolved Hide resolved
<li><p><a>This</a>'s <a>relevant global object</a> has <a>transient activation</a>.
</ul>

<li><p>Return <var>promise</var>, and run the remaining steps <a>in parallel</a>.
Expand Down Expand Up @@ -465,6 +457,8 @@ could be an open <{dialog}> element.

<li><p>Return <var>promise</var>, and run the remaining steps <a>in parallel</a>.

<li><p>Run the [=fully unlock the screen orientation steps=] with <var>doc</var>.

<li><p>If <var>resize</var> is true, resize <var>doc</var>'s viewport to its "normal" dimensions.

<li><p>If <var>doc</var>'s <a>fullscreen element</a> is null, then resolve <var>promise</var> with
Expand Down