Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide popovers when making an element fullscreen #204

Merged
merged 16 commits into from
May 22, 2023
Merged

Hide popovers when making an element fullscreen #204

Changes from 13 commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
c94701e
Hide pop-ups when making an element fullscreen
josepharhar Oct 18, 2022
404bf0d
Don't allow fullscreen on showing popovers
josepharhar Nov 11, 2022
8c7ef0c
https://chromium-review.googlesource.com/c/chromium/src/+/4032790
josepharhar Nov 18, 2022
15648d0
Fix popover showing state reference
josepharhar Feb 14, 2023
cf5bc17
Replace pronouns
josepharhar Feb 14, 2023
73a1ae1
change hide all popups until to hide all popovers
josepharhar Mar 25, 2023
694eef1
Merge branch 'main' into popup
josepharhar Mar 25, 2023
dbaef78
fix popover showing state reference
josepharhar Mar 25, 2023
25c9af0
Update fullscreen.bs
foolip Apr 6, 2023
a59d9f2
Update fullscreen.bs
foolip Apr 6, 2023
e5eb313
Update fullscreen.bs
foolip Apr 6, 2023
a01f314
Update fullscreen.bs
foolip Apr 6, 2023
b710367
Update fullscreen.bs
foolip Apr 6, 2023
ad47d02
Update fullscreen.bs
foolip Apr 6, 2023
a1b9c10
add HTML element check
josepharhar Apr 10, 2023
4d375fe
wrap long line
josepharhar May 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions fullscreen.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,8 +61,16 @@ stated otherwise it is unset.
<p>All <a for=/>documents</a> have an associated <dfn>list of pending fullscreen events</dfn>, which
is an <a>ordered set</a> of (<a>string</a>, <a>element</a>) <a>tuples</a>. It is initially empty.

<p>To <dfn>fullscreen an <var>element</var></dfn>, set <var>element</var>'s <a>fullscreen flag</a>
and <a for="top layer">add</a> it to its <a>node document</a>'s <a>top layer</a>.
<p>To <dfn>fullscreen an <var>element</var></dfn>:

<ol>
<li><p>Run <a>hide all popovers</a> given <var>element</var>'s <a>node document</a>.

<li><p>Set <var>element</var>'s <a>fullscreen flag</a>.

<li><p><a for="top layer">Add</a> <var>element</var> to <var>element</var>'s <a>node document</a>'s
<a>top layer</a>.
</ol>

<p>To <dfn>unfullscreen an <var>element</var></dfn>, unset <var>element</var>'s
<a>fullscreen flag</a> and <a>iframe fullscreen flag</a> (if any), and <a for=set>remove</a> it from
Expand Down Expand Up @@ -230,6 +238,8 @@ if all of the following are true, and false otherwise:
<li><p><var>element</var>'s <a>node document</a> is <a>allowed to use</a> the "<code><a
data-lt="fullscreen-feature">fullscreen</a></code>" feature.
<!-- cross-process, recursive -->

<li><p><var>element</var>'s <a>popover visibility state</a> is not <a for="popover visibility state">showing</a>.
foolip marked this conversation as resolved.
Show resolved Hide resolved
</ul>

<div algorithm="requestFullscreen(options)">
Expand Down