Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract dag descriptor dao #92

Merged
merged 130 commits into from
Oct 29, 2024
Merged

Extract dag descriptor dao #92

merged 130 commits into from
Oct 29, 2024

Conversation

techloghub
Copy link
Collaborator

No description provided.

Copy link

codecov bot commented Oct 28, 2024

Codecov Report

Attention: Patch coverage is 83.26360% with 80 lines in your changes missing coverage. Please review.

Project coverage is 39.70%. Comparing base (7b981e0) to head (e9b6979).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
.../service/converter/DAGDescriptorConverterImpl.java 81.93% 10 Missing and 18 partials ⚠️
...ill/flow/service/service/DAGDescriptorService.java 80.95% 8 Missing and 4 partials ⚠️
...traversal/mappings/JSONPathInputOutputMapping.java 78.12% 2 Missing and 5 partials ⚠️
...bo/rill/flow/service/storage/dao/DAGABTestDAO.java 78.78% 4 Missing and 3 partials ⚠️
...ibo/rill/flow/service/storage/dao/DAGAliasDAO.java 81.25% 4 Missing and 2 partials ⚠️
...ibo/rill/flow/service/facade/DAGRuntimeFacade.java 0.00% 4 Missing ⚠️
...a/com/weibo/rill/flow/controller/BgController.java 0.00% 4 Missing ⚠️
...weibo/rill/flow/olympicene/core/model/dag/DAG.java 0.00% 2 Missing ⚠️
...low/service/dispatcher/FunctionTaskDispatcher.java 0.00% 2 Missing ⚠️
...ll/flow/olympicene/core/model/task/ChoiceTask.java 0.00% 1 Missing ⚠️
... and 7 more
Additional details and impacted files
@@             Coverage Diff              @@
##               main      #92      +/-   ##
============================================
+ Coverage     34.74%   39.70%   +4.95%     
- Complexity      934     1119     +185     
============================================
  Files           187      196       +9     
  Lines          7927     8078     +151     
  Branches        675      699      +24     
============================================
+ Hits           2754     3207     +453     
+ Misses         4974     4638     -336     
- Partials        199      233      +34     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Oct 29, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot

See analysis details on SonarCloud

@qdaxb qdaxb merged commit d52996e into main Oct 29, 2024
4 of 5 checks passed
@qdaxb qdaxb deleted the extract_dag_descriptor_dao branch October 29, 2024 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants