readme.md update etcd v2 and v3 description #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiaokai-wang
reviewed
Apr 7, 2023
| @@ -323,6 +323,15 @@ or | |||
| Etcd_interface | |||
| ====== | |||
|
|
|||
| **crucial** | |||
There was a problem hiding this comment.
想了下，放在这里感觉有点不合适，这里只是介绍接口使用方式，而且v2、v3 在这里是一致的；
应该放在Compatibility 下？当前这个标题下只涉及了nginx 的兼容性，consul 和 etcd 的都没涉及，能帮忙在这个标题下面加三个二级标题吗？nginx、consul、etcd，其中nginx 就是当前的内容，consul 支持v1 版本，etcd 支持v2、v3，但是v3 需要etcdv3_upsync_proxy[https://github.com/reatang/etcdv3_upsync_proxy] 的代理才可以work；
类似上面的结构，你觉得咋样？谢谢.
|
@reatang thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.