feat: Add historyApiFallback option #930
Conversation
drudrum
requested review from
alexander-akait,
hiroppy and
snitin315
as code owners
|
I add new branch and write right commit message original pull request #922 |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #930 +/- ##
==========================================
- Coverage 97.34% 94.84% -2.51%
==========================================
Files 9 10 +1
Lines 377 291 -86
Branches 112 103 -9
==========================================
- Hits 367 276 -91
- Misses 9 13 +4
- Partials 1 2 +1
... and 10 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
|
I am sorry. I was make commit via vs code. |
|
Don't worry, I will squash them before merge |
|
@hiroppy something wrong? |
|
All fine, I will finish dev server stable release and will improve dev middleware, more caches, features, less build time and other |
src/utils/getFilenameFromUrl.js
Outdated
| if ( | ||
| options.historyApiFallback && | ||
| !context.outputFileSystem.existsSync(filename) | ||
| ) { | ||
| filename = path.join(outputPath); | ||
| } |
There was a problem hiding this comment.
When pathname is empty, with this option we will also try find index.html at correct folder
remove difference
order change
|
I still have light feeling that we do something wrong because logic |
This PR contains a:
Motivation / Use-Case
Add useful option historyApiFallback.
Ability to use React Router5
like as webpackDevServer https://webpack.js.org/configuration/dev-server/#devserverhistoryapifallback
Breaking Changes
Additional Info