-
-
Notifications
You must be signed in to change notification settings - Fork 601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: migrate configtest
package to ESM
#3439
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe draft these ESM converted packages and group them up, until every package is done migrated?
Yes, I'll convert this to a draft. |
@snitin315 I think in this PR we need to convert all to ESM (or alternative we can use |
a7593f2
to
7cc6bd5
Compare
…3290) BRAKING CHANGE: the `--hot` option was removed for `webpack build` and `webpack watch` commands in favor directly usage `HotModuleReplacement` plugin
BREAKING CHANGE: the `--prefetch` option was removed without replacement
* fix(webpack-cli): add an option for preventing interpret * fix: define the option for built-in flags * docs: add descriptions of the option * refactor: rename `--config-registered` to `--disable-interpret` * fix: change conditional statement * refactor: standalone test * test: use `--disable-interpret` without transpilation * docs: fix the description Co-authored-by: Anshuman Verma <[email protected]> * refactor: built-in options type Co-authored-by: Nitin Kumar <[email protected]> * test: re-update snapshots * fix: add double quote Co-authored-by: Nitin Kumar <[email protected]> * test: update snapshots for webpack4 * chore: remove `--require` from `test:coverage` * test: update snapshots Co-authored-by: Anshuman Verma <[email protected]> Co-authored-by: Nitin Kumar <[email protected]>
BREAKING CHANGE: webpack-cli no longer supports webpack v4, the minimum supported version is webpack v5.0.0
…0.0` (#3353) * refactor!: the minimun supported webpack-dev-server version in v4.0.0 * refactor: remove unused type
7cc6bd5
to
e0737fe
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## next #3439 +/- ##
=======================================
Coverage 84.82% 84.82%
=======================================
Files 22 22
Lines 1588 1588
Branches 447 447
=======================================
Hits 1347 1347
Misses 241 241 Continue to review full report at Codecov.
|
@alexander-akait I suppose if we move to ESM it will break compatibility with webpack v5 too. Because webpack 5 is using cli with |
@snitin315 What about if we will use |
@alexander-akait yes but it means from webpack v5.0.0 to the current latest version of webpack will not work with this major version. It will be compatible only with future version of webpack which is using import(). |
Hm, I cannot undestand... Webpack can have any type - commonjs or ESM, we just load it using |
@alexander-akait Yes |
@snitin315 Oh, I got it, yeah, let's postpone it then, and mark it for webpack v6, we will need to do it for webpack-dev-server too |
@alexander-akait yes, let's postpone. |
Let's close in favor #3436, I think we will start migration everywhere on ESM when Node.js@18 will be outdated, because there are some bugs in Node.js@18 with ESM and especial with |
What kind of change does this PR introduce?
refactor.
Did you add tests for your changes?
No
If relevant, did you update the documentation?
No
Summary
Start ESM migration.
Does this PR introduce a breaking change?
No
Other information
No