changed HashSet to LinkedHashSet to fix flaky test (#52)

Co-authored-by: Stefan Seifert <[email protected]>
wcm-io · Nov 15, 2024 · 73a80e6 · 73a80e6
1 parent d973411
commit 73a80e6
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/changes.xml b/changes.xml
@@ -27,6 +27,9 @@
       <action type="update" dev="sseifert">
         Update to latest OSGi Mock.
       </action>
+      <action type="fix" dev="Benjamin Guan" issue="52">
+        MockTagManager.getTagsForSubtree: Ensure stable order of result list.
+      </action>
     </release>
 
     <release version="5.6.2" date="2024-09-16">

diff --git a/core/src/main/java/io/wcm/testing/mock/aem/MockTagManager.java b/core/src/main/java/io/wcm/testing/mock/aem/MockTagManager.java
@@ -28,6 +28,7 @@
 import java.util.HashMap;
 import java.util.HashSet;
 import java.util.Iterator;
+import java.util.LinkedHashSet;
 import java.util.LinkedList;
 import java.util.List;
 import java.util.Locale;
@@ -377,7 +378,7 @@ private Collection<Tag> collectResourceTags(Resource resource, boolean recurse)
     if (resource == null) {
       return Collections.emptyList();
     }
-    Set<Tag> treeTags = new HashSet<>();
+    Set<Tag> treeTags = new LinkedHashSet<>();
     Queue<Resource> searchResources = new LinkedList<>();
     searchResources.add(resource);