Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check write permissions for configurations, show storage path #31

Merged
merged 17 commits into from
Apr 10, 2024

Conversation

stefanseifert
Copy link
Member

Fixes #25

@stefanseifert stefanseifert marked this pull request as ready for review March 19, 2024 15:03
@stefanseifert
Copy link
Member Author

@kwin: can you test this PR?
it both adds a (i) button to show the actual persist path, and also renders the config details dialog readonly if the current user does not have write permission to this path.

@kwin
Copy link
Contributor

kwin commented Mar 28, 2024

Looks good in general, just a small visual glitch with the icon not horizontally aligned with the preceding text:

Screenshot 2024-03-28 at 19 41 13

I could fix this by removing the css style line-height set for .coral3-Button--minimal:
Screenshot 2024-03-28 at 19 43 43

@stefanseifert
Copy link
Member Author

Looks good in general, just a small visual glitch with the icon not horizontally aligned with the preceding text:

that was in AEM 6.5 only - i've fixed this in fd84149

Copy link

sonarcloud bot commented Apr 10, 2024

@stefanseifert stefanseifert merged commit 50ecfcc into develop Apr 10, 2024
7 checks passed
@stefanseifert stefanseifert deleted the feature/readonlyCheck branch April 10, 2024 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Expose write location in repository
2 participants