Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github Workflow fixes #2

Open
wants to merge 46 commits into
base: wasp-os
Choose a base branch
from
Open

Conversation

LatantSea
Copy link

Allows the project to be compiled through Github Actions and the results to be downloaded as an artifact.

Allows artifacts to be downloaded when not building a release. Useful for hobbyists.
Fixed a call to 'upload_release_files.py' not having access to the /bin directory
'pnvram' is only defined for nrf52832 boards. Builds for other boards were preventing the entire project from building on Github Actions.
@daniel-thompson
Copy link
Collaborator

Thanks for the getting in touch however I'm afraid I can't really take this series as it is.

First and foremost the version history is not structured to make review possible. 46 commits without any descriptions of the reason for each commit is not reviewable. Take a look at the recent commits in the main wasp-os branch to get a sense of how commits should be structured to make it possible to review them.

There are a couple of other related activities taking place that you might like to be aware of.

I'm afraid I fixed the CI builds this afternoon and didn't notice this PR until after I had done so. That's my fault not yours... I overlooked the notification e-mail but nevertheless I have already pushed my fix.

Finally there are a couple of developers on the wasp-os repo working to build all the wasp-os artefacts and make them available in one place. See wasp-os/wasp-os#52 and wasp-os/wasp-os#53 for details and https://github.com/AlwaysLivid/wasp-os/actions/runs/196271359 if you want to see an example of the artefacts.

@n0toose
Copy link

n0toose commented Aug 17, 2020

@LatantSea Please reach out to us, we'd appreciate your help and I'd love to discuss some of the things regarding the PR with you.

@LatantSea
Copy link
Author

Hey, thank you for your patience, I'm new to Github. I'm still very unfamiliar with the features and interface.
@daniel-thompson Thank you for your response and direction. I'll try to emulate the pre-existing commit structure for future commits
@AlwaysLivid On what may I assist? I'm currently working on a classic card game clone for Wasp-os while learning micropython

@n0toose
Copy link

n0toose commented Aug 17, 2020

@AlwaysLivid On what may I assist? I'm currently working on a classic card game clone for Wasp-os while learning micropython

We already have some sort of implementation under development which is meant to stay true to what the documentation describes, but there are a decent amount of technicalities that need to get done right and fixed before considering it.

If you could reach out to me privately, I'd be able to discuss what we currently "have in store" and what needs to be worked on. I believe that discussing a completely irrelevant pull request over here would seem kind of inappropriate, but both me and Mirko have been a bit busy and could probably make use of a helping hand. :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants