Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unnecessary type conversions #1325

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

samueltardieu
Copy link
Contributor

@samueltardieu samueltardieu commented Nov 29, 2024

Detected during an extension of the useless_conversion Clippy lint.

Copy link

codecov bot commented Nov 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.63%. Comparing base (4cf45ad) to head (31182eb).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1325      +/-   ##
==========================================
+ Coverage   81.61%   81.63%   +0.01%     
==========================================
  Files         305      305              
  Lines       25288    25283       -5     
==========================================
- Hits        20640    20639       -1     
+ Misses       4648     4644       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Robbepop
Copy link
Member

@samueltardieu Thanks a lot for the improvements. Weird that our CI did not catch those.

@Robbepop Robbepop merged commit 1432670 into wasmi-labs:main Nov 29, 2024
19 checks passed
@samueltardieu
Copy link
Contributor Author

Weird that our CI did not catch those.

Not really, I made the patch for Clippy a few hours ago, it is not even merged yet. It should appear in nightly Clippy in a few days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants