Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add known_issues tests #87

Merged
merged 7 commits into from
Nov 18, 2024
Merged

Add known_issues tests #87

merged 7 commits into from
Nov 18, 2024

Conversation

AYAHASSAN287
Copy link
Collaborator

@AYAHASSAN287 AYAHASSAN287 commented Nov 12, 2024

PR Details

  • This PR contains 2 tests :

1-test_multiple_edge_service_nodes_communication

based on the example in explanation series :

  • 2 edge nodes & 3 service nodes
  • Edge_node1 publish lighpush message to peer service_node1
  • Service_node1 relays message to service_node2 & service_node3
  • Edge_node2 makes store query to service_node2
  • Edge_node2 makes filter request to service_node3
  • Service_node3 makes store query to service_node2

2-test_store_no_peer_selected
Test written based on bug Store-query node auto-pick doesn't work as expected

  • 5 nodes created [ 1 store node ]
  • Node4(relay node) publish message
  • Adding 3 peers to Node3 [1 store node - 2 non store nodes]
  • Node3 (non relay node makes store inquiry but no store node specified
  • Steps repeated for store_version 1

Issues reported:

For test test_multiple_edge_service_nodes_communication :

when both the sender and lightpush node are go-waku ---- > no issues
if any of them nwaku publish fails

For test test_store_no_peer_selected:
If go-waku node active
Store requests fails for both store v1 & v3

@AYAHASSAN287 AYAHASSAN287 marked this pull request as draft November 12, 2024 11:28
@AYAHASSAN287 AYAHASSAN287 changed the title Add draft test for example edge/service nodes Add known_issues tests Nov 18, 2024
@AYAHASSAN287 AYAHASSAN287 marked this pull request as ready for review November 18, 2024 08:06
@fbarbu15 fbarbu15 self-requested a review November 18, 2024 09:26
@AYAHASSAN287 AYAHASSAN287 merged commit 348a14c into master Nov 18, 2024
3 of 4 checks passed
@AYAHASSAN287 AYAHASSAN287 deleted the Known_issues_tests branch November 18, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants