Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: added metrics for total proofs and remaining proofs per epoch. #3181

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

chore: added metrics for total proofs and remaining proofs per epoch. #3181

wants to merge 7 commits into from
+5,758 −559

Conversation

darshankabariya
Copy link
Contributor

@darshankabariya darshankabariya commented Nov 26, 2024 •
edited
Loading

This PR adds two Grafana panels: one displays the total number of RLN proofs generated till now, and the other shows the remaining RLN proofs per epoch. These panels enable users to monitor the available proofs for the upcoming minutes effectively.

close #3024

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 26, 2024 •
edited
Loading

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:3181

Built from a207973

@darshankabariya darshankabariya changed the title chore: Grafana panal for remaining proof per epoch chore: grafana panal for remaining proof per epoch Nov 26, 2024
@darshankabariya darshankabariya mentioned this pull request Nov 26, 2024
Open
gabrielmer
gabrielmer reviewed Nov 27, 2024
View reviewed changes
Copy link
Contributor

@gabrielmer gabrielmer left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much! I see the new metrics, but where are the panels mentioned in the PR description?

waku/waku_rln_relay/protocol_metrics.nim
@@ -62,6 +62,16 @@ declarePublicGauge(
"time taken to import membership credentials",
)

declarePublicCounter(
waku_rln_proofs_generated_total,
"number of RLN proofs generated by this light client for the current epoch",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this isn't for light clients specifically

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ! will improve terminology.

waku/waku_rln_relay/group_manager/group_manager_base.nim Show resolved Hide resolved
@darshankabariya
Copy link
Contributor Author

Thanks so much! I see the new metrics, but where are the panels mentioned in the PR description?

Actually, I also raised a PR for the nwaku-compose repository to address the dashboard. I thought it would be better to get approval there first and then copy it here.

@gabrielmer
Copy link
Contributor

Actually, I also raised a PR for the nwaku-compose repository to address the dashboard. I thought it would be better to get approval there first and then copy it here.

Oh got it! So better to change this PR name to reflect that what you're adding here are metrics and not a Grafana panel

gabrielmer
gabrielmer approved these changes Nov 27, 2024
View reviewed changes
Copy link
Contributor

@gabrielmer gabrielmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@darshankabariya darshankabariya changed the title chore: grafana panal for remaining proof per epoch chore: added metrics for total proofs and remaining proofs per epoch. Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabrielmer gabrielmer gabrielmer approved these changes

@Ivansete-status Ivansete-status Awaiting requested review from Ivansete-status

@AlbertoSoutullo AlbertoSoutullo Awaiting requested review from AlbertoSoutullo

@NagyZoltanPeter NagyZoltanPeter Awaiting requested review from NagyZoltanPeter

At least 2 approving reviews are required to merge this pull request.

Assignees

@darshankabariya darshankabariya

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

chore: create new RLN Grafana panel that counts the number of attached proofs per light client
2 participants
@darshankabariya @gabrielmer