feat: making dns discovery async #3175
Merged
+101
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can find the image built from this PR at Built from a5588af |
gabrielmer
force-pushed
the
feat-dns-discovery-backoff
branch
from
8f8d588
to
5551809
Compare
gabrielmer
requested review from
Ivansete-status,
richard-ramos,
darshankabariya and
NagyZoltanPeter
Ivansete-status
approved these changes
Dec 2, 2024
waku/factory/waku.nim
Outdated
| @@ -400,3 +439,6 @@ proc stop*(waku: Waku): Future[void] {.async: (raises: [Exception]).} = | |||
|
|
|||
| if not waku.node.isNil(): | |||
| await waku.node.stop() | |||
|
|
|||
| if waku.dnsRetryLoopHandle.isSome(): | |||
There was a problem hiding this comment.
I think it could be a little bit simpler by just checking if dnsRetryLoopHandle is not nil. I'd suggest to avoid using Option as much as possible but is just a personal nitpick, not a big difference though ;P
There was a problem hiding this comment.
Superr. good point! Updated it - I agree that it's nicer and simpler without the Option :)
Thank you!
This reverts commit f35ded4.
gabrielmer
force-pushed
the
feat-dns-discovery-backoff
branch
from
6db2aab
to
b9d8ddc
Compare
richard-ramos
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Instead of exiting if DNS Discovery fails at startup, we now create a loop that attempts to perform DNS Discovery every 30 seconds until it succeeds.
Changes
wakunode2nim-dnsdiscsubmoduleHow to test
Run
wakunode2configuring discv5 and dns-discovery with the internet connection off, then turn it on after some time and see that DNS Discovery is performed and Discv5 finds peersIssue
#3076