Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: CHANGELOG.md for v0.34.0 #3159

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

chore: CHANGELOG.md for v0.34.0 #3159

wants to merge 9 commits into from

Conversation

NagyZoltanPeter
Copy link
Contributor

Description

Changelog for v0.34.0

Please read through and add any highlight for this release as needed.

Changes

  • changelog update

@NagyZoltanPeter NagyZoltanPeter self-assigned this Oct 29, 2024
SionoiS
SionoiS approved these changes Oct 29, 2024
View reviewed changes
Copy link
Contributor

@SionoiS SionoiS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

CHANGELOG.md Outdated Show resolved Hide resolved
@gabrielmer
Copy link
Contributor

gabrielmer commented Oct 29, 2024 •
edited
Loading

I just noticed that for 0.34 we have the milestone to remove the protectedTopic CLI flag https://github.com/waku-org/nwaku/milestone/22

I'll add a PR for it right now. Is it possible to add it to the release and include a note here in the changelog announcing that we removed it? 😶

update: this is the PR: #3160

@NagyZoltanPeter
Copy link
Contributor Author

I just noticed that for 0.34 we have the milestone to remove the protectedTopic CLI flag https://github.com/waku-org/nwaku/milestone/22

I'll add a PR for it right now. Is it possible to add it to the release and include a note here in the changelog announcing that we removed it? 😶

update: this is the PR: #3160

I will cherry pick it.

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 30, 2024 •
edited
Loading

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:3159

Built from 67cb991

NagyZoltanPeter and others added 4 commits October 30, 2024 14:32
@NagyZoltanPeter
fix lint error
04ec145
@gabrielmer @NagyZoltanPeter
chore: removing protected-topic cli flg (#3160)
7ac1ebc
@NagyZoltanPeter
chore: Partial version bumps for v0.34.0-rc.1 (#3172)
e3b84e3 
* Bumps for v0.34.0-rc.1 - partial bumping - libp2p
* Avoid importing quic and ngtcp2 dependencies through tests
* libp2p 1.7.1, fixes RendezVous construction
@NagyZoltanPeter
no-code-change, extended changlog with notice of removed protected-to…
d9a4ddb 
…pic cli config
Ivansete-status
Ivansete-status reviewed Nov 21, 2024
View reviewed changes
Copy link
Collaborator

@Ivansete-status Ivansete-status left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks great thanks!
I just added some minor comments.
We need to update the PR's title and description to properly reflect the underlying changes.
Not approving yet as per one question I ask re pre-release-yml.

CHANGELOG.md Outdated
Comment on lines 4 to 6



Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a super nitpick one, may remove the extra lines :)?

Suggested change

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
.github/workflows/pre-release.yml Outdated
@@ -159,5 +159,5 @@ jobs:
TARGET=$([[ "${{ needs.tag-name.outputs.tag }}" == "nightly" ]] && echo "--target ${{steps.vars.outputs.ref}}" || echo "")

gh release create ${{ needs.tag-name.outputs.tag }} --prerelease ${TARGET} \
--title ${{ needs.tag-name.outputs.tag }} --notes-file release_notes.md \
wakunode2/* wakutools/*
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this isn't needed now :)?

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
Ivansete-status
Ivansete-status reviewed Nov 21, 2024
View reviewed changes
Copy link
Collaborator

@Ivansete-status Ivansete-status left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks great thanks!
I just added some minor comments.
We need to update the PR's title and description to properly reflect the underlying changes.
Not approving yet as per one question I ask re pre-release-yml.

gabrielmer
gabrielmer approved these changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@gabrielmer gabrielmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ivansete-status Ivansete-status Ivansete-status left review comments

@gabrielmer gabrielmer gabrielmer approved these changes

@SionoiS SionoiS SionoiS approved these changes

@richard-ramos richard-ramos Awaiting requested review from richard-ramos

@darshankabariya darshankabariya Awaiting requested review from darshankabariya

Assignees

@NagyZoltanPeter NagyZoltanPeter

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@NagyZoltanPeter @gabrielmer @SionoiS @Ivansete-status