feat: waku rendezvous wrapper #2962
Conversation
|
You can find the image built from this PR at Built from 8228856 |
|
|
SionoiS
force-pushed
the
feat--waku-rendezvous
branch
from
d5247ba
to
3e651ee
Compare
SionoiS
force-pushed
the
feat--waku-rendezvous
branch
from
bffa68b
to
6014283
Compare
SionoiS
requested review from
darshankabariya,
gabrielmer,
NagyZoltanPeter and
Ivansete-status
| ./common | ||
|
|
||
| logScope: | ||
| topics = "waku rendez vous" |
There was a problem hiding this comment.
| topics = "waku rendez vous" | |
| topics = "waku rendezvous" |
I would personally write "rendezvous" everywhere instead of "rendez vous" for consistency (it will also make everything easier when performing searches)
There was a problem hiding this comment.
Yes, sorry for that in French it's 2 words not one...
| continue | ||
|
|
||
| # Ask for 12 peer records for that shard | ||
| self.request(namespace, 12, @[rpi.peerId]) |
There was a problem hiding this comment.
wouldn't be better to have a constant instead of hardcoding 12?
| # start registering forever | ||
| self.periodicRegistrationFut = self.periodicRegistration() | ||
|
|
||
| proc stopWait*(self: WakuRendezVous) {.async: (raises: []).} = |
There was a problem hiding this comment.
I think we're not calling stopWait() anywhere. Shouldn't we add it to a stop() proc so it gets executed when calling node.wakuRendezvous.stop()?
I will add some tests but nim-libp2p already tests the functionalities. |
Description
I've wrapped libp2p rendezvous protocol so that at the waku layer we can register at rdv points and also request peer records.
spec -> https://github.com/waku-org/specs/blob/master/standards/core/rendezvous.md
Changes