chore(tests): Simplify imports #2467
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can find the image built from this PR at Built from 9f9519f |
AlejandroCabeza
force-pushed
the
fix-test-imports
branch
from
1a4d344
to
814b9e7
Compare
AlejandroCabeza
force-pushed
the
fix-test-imports
branch
from
814b9e7
to
3ded04b
Compare
AlejandroCabeza
changed the title
AlejandroCabeza
force-pushed
the
fix-test-imports
branch
from
64f276f
to
49256dc
Compare
AlejandroCabeza
force-pushed
the
fix-test-imports
branch
from
80d0dd0
to
f4cd398
Compare
rymnc
reviewed
Mar 19, 2024
There was a problem hiding this comment.
my intuition is that this test was never imported anywhere and that is why we could not catch it while merging the rln-v2 changes m
There was a problem hiding this comment.
Agree, those were my findings as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Simplify test imports
Changes
test_allfilesall_test_wakuusingtest_allfiles