-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add consume user activation of Window #1695
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM from a HTML editor perspective, setting aside for now #1696. Not sure what the procedure is around here for when something is mergeable (implementer interest etc.).
Implemented it WebKit for internal tests (not Safari Driver): I'm pretty happy with it! The tests are super nice now. No more window.open() or requestFullscreen() business!!!! 🥳🎉 |
A requirement to getting this merged appears to be having WPT tests. However, I had a look at the existing tests and they are unfortunately written in Python (I have zero Python knowledge... so little knowledge, in fact, that I don't know if it's "python" or "Python"). I can try to copy/paste my way to success, but could use some help with those. |
It would also be good to understand if this is something that has implementor interest to actually ship to web devs in WebDriver. If not it should perhaps be in the testutils spec instead. |
This seems to be pretty important to web developers too, as user activation can expire if things they are doing, fetch()’ing, or processing take too long. This gives them an opportunity to test for such cases and come up with strategies for recovery. |
I think this makes sense. @vladimir-nechaev @sadym-chromium do you think this makes sense for chromedriver? If we file a chromedriver bug and merge this spec PR, is it something you'd be able to implement easily, or does it seem involved? |
Sent web-platform-tests/wpt#37176 for testdriver.js |
With apologies for creating work here: I think we should move this proposal into the HTML spec rather than in the base WebDriver spec. There are a few reasons for that:
Sorry for not suggesting this right away; I didn't immediately think of it, but once the idea came up it seemed like very much the best option. |
FWIW, I believe there is another example in the Secure Payment Confirmation spec of how to define a new WebDriver extension command; see the RFC for details. |
Thanks @jgraham, @javifernandez, I'll move it to HTML instead. |
HTML PR is at whatwg/html#8609 |
Closes #1691
Related discussion web-platform-tests/wpt#36727
RFC for Web Platform Tests: web-platform-tests/rfcs#128
Implementation in testdriver.js: web-platform-tests/wpt#37176
Preview | Diff