-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove definitions of MutationEvent and friends #381
Conversation
Please see this WHATWG/dom issue for more details: whatwg/dom#305 (comment) Mutation events have now been disabled for most all users of the Chrome browser. While there are still a few sites opted back in to the events via origin trial tokens, those are time limited and we've committed to end-date them as soon as possible. However, it feels appropriate to remove the definition of these deprecated events from the standard at this point.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, I might have merge permissions on this repository? Let's give it a shot...
Guess you do! Thanks! |
Hmm it's still appearing in https://w3c.github.io/uievents/ though. I think maybe because there are actually many files in this repo, several of which still mention MutationEvent? https://github.com/search?q=repo%3Aw3c%2Fuievents+mutationevent&type=code |
Weird - I definitely left some references to mutation events there, and I'll put up another PR to remove those. But I'm guessing something else needs to get run to re-publish, since none of my removals seem to be published. E.g. this section doesn't exist in the source, at least that I can see. |
No, that's not necessarily true. I think github search maybe just missed them. I'll put up another PR and let's see what it looks like after that one. |
Ok, #382. I really don't get how this repo is supposed to be built, because it seems like |
The build script only generates the .bs files from the .txt files. The final .html files are generated by an auto-publish process, so they are not checked in. The files in the split directory were an experiment from earlier this year that are not active. I will be removing them. |
Just to confirm - looks like they're all gone now.
This explains my confusion. I'm used to editing .bs files, not having those be build targets. Perhaps it'd be a good idea not to include the |
Please see this WHATWG/dom issue for more details:
whatwg/dom#305 (comment)
Mutation events have now been disabled for most all users of the Chrome browser. While there are still a few sites opted back in to the events via origin trial tokens, those are time limited and we've committed to end-date them as soon as possible. However, it feels appropriate to remove the definition of these deprecated events from the standard at this point.
The following tasks have been completed:
Confirmed there are no ReSpec/BikeShed errors or warnings.
Modified Web platform tests (link to pull request)
Add mutation events to "historical" WPT web-platform-tests/wpt#47727
Implementation commitment: