Allow unlock() to return a promise #231
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcoscaceres
force-pushed
the
unlock_promise
branch
from
cd10353
to
3c160e3
Compare
|
Doesn't this have the problem that the promise is resolved before the lock might have been applied? (As that happens in parallel.) |
|
It shouldn't (though maybe I didn't word it right?). That definitely should never happen: in parallel, (un)locking happens, maybe the event fires if the orientation changed, then the promise is resolved. |
|
I think I understand, I got confused due to it sometimes early returning a successful promise. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #104
The following tasks have been completed:
Implementation commitment:
Preview | Diff