You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a TypeScript only improvement
It allows to pass a special case like this:
<scriptsetuplang="ts">// import type { MyItem } from '@/shared/models/MyItem';import{ref}from'vue';interfaceNodeIdextendsString{// ^^^^^^ this is the important part for the reason of this PR_nodeIdBrand: string;}interfaceMyItemIdextendsNodeId{_myItemIdBrand: string;}interfaceMyItemextendsBaseNode<MyItemId>{label: string;}constitems=ref<MyItem[]>([/*...*/]);functiontoAny(value: any): any{returnvalue;}</script><templatelang="pug">ul//- Previously I needed this: li(v-for="item in items", :key="toAny(item.id)")li(v-for="item in items", :key="item.id")span{{item.label}}</template>
Yeah I know, literally the first sentence in the PR description says that 😅
There is already another PR to solve the issue you are trying to explain
But this is not my issue and it seems like it doesn't get priority
So I opened this one to give at least a fix for my case
I do not use objects and I don't want to use objects as key as I think that is bad practice
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a TypeScript only improvement
It allows to pass a special case like this: