Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(runtime-core): checkDuplicateKeys in patchKeyedChildren&mountChildren #3079

Closed
wants to merge 11 commits into from
Closed

fix(runtime-core): checkDuplicateKeys in patchKeyedChildren&mountChildren #3079

wants to merge 11 commits into from

Conversation

edison1105
Copy link
Member

@edison1105 edison1105 commented Jan 21, 2021 •
edited
Loading

close #3082

consistent with Vue2

CI failures is about e2e test.

@posva
Copy link
Member

posva commented Jan 21, 2021 •
edited
Loading

if the code is being fixed there must be a test case that was failing before

@edison1105 edison1105 changed the title feat(runtime-core): checkDuplicateKeys in patchKeyedChildren feat(runtime-core): checkDuplicateKeys in patchKeyedChildren&mountChildren Jan 21, 2021
@edison1105
Copy link
Member Author

if the code is being refactored there must be a test case that was failing before

makes sense, I added the test cases

@edison1105 edison1105 changed the title feat(runtime-core): checkDuplicateKeys in patchKeyedChildren&mountChildren fix(runtime-core): checkDuplicateKeys in patchKeyedChildren&mountChildren Jan 21, 2021
@Mr14huashao
Copy link

If you can, please rebase your code in your PR, which helps us understand your solution.
Thanks ^_^

@HcySunYang HcySunYang mentioned this pull request Mar 12, 2021
Open
@HcySunYang HcySunYang added the 🍰 p2-nice-to-have Priority 2: this is not breaking anything but nice to have it addressed. label Mar 19, 2021
skirtles-code
skirtles-code reviewed Mar 30, 2021
View reviewed changes
Copy link
Contributor

@skirtles-code skirtles-code left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some code suggestions.

I don't think #2633 should be closed by this PR. Only one aspect of that issue is addressed here. Update: This PR's description has been updated to avoid closing #2633.

packages/runtime-core/src/renderer.ts Outdated Show resolved Hide resolved
packages/runtime-core/src/renderer.ts Outdated Show resolved Hide resolved
packages/runtime-core/src/renderer.ts Outdated Show resolved Hide resolved
@edison1105 edison1105 requested a review from posva March 30, 2021 11:31
@yyx990803
Copy link
Member

#3082 (comment)

@yyx990803 yyx990803 closed this May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skirtles-code skirtles-code skirtles-code left review comments

@posva posva Awaiting requested review from posva

@HcySunYang HcySunYang Awaiting requested review from HcySunYang

Assignees
No one assigned
Labels
🍰 p2-nice-to-have Priority 2: this is not breaking anything but nice to have it addressed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Duplicate keys check does not working
6 participants
@edison1105 @posva @Mr14huashao @yyx990803 @HcySunYang @skirtles-code