Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compat): don't warn deprecation if compat config is disabled #12447

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

noootwo
Copy link
Contributor

@noootwo noootwo commented Nov 20, 2024

fix #12443

Copy link

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 100 kB 37.9 kB 34.2 kB
vue.global.prod.js 158 kB 57.8 kB 51.4 kB

Usages

Name Size Gzip Brotli
createApp (CAPI only) 47.2 kB 18.3 kB 16.8 kB
createApp 55.2 kB 21.3 kB 19.5 kB
createSSRApp 59.3 kB 23.1 kB 21 kB
defineCustomElement 60.1 kB 22.9 kB 20.8 kB
overall 69.1 kB 26.5 kB 24.1 kB

Copy link

pkg-pr-new bot commented Nov 20, 2024

Open in Stackblitz

@vue/compiler-core

pnpm add https://pkg.pr.new/@vue/compiler-core@12447

@vue/compiler-ssr

pnpm add https://pkg.pr.new/@vue/compiler-ssr@12447

@vue/compiler-sfc

pnpm add https://pkg.pr.new/@vue/compiler-sfc@12447

@vue/reactivity

pnpm add https://pkg.pr.new/@vue/reactivity@12447

@vue/compiler-dom

pnpm add https://pkg.pr.new/@vue/compiler-dom@12447

@vue/runtime-core

pnpm add https://pkg.pr.new/@vue/runtime-core@12447

@vue/runtime-dom

pnpm add https://pkg.pr.new/@vue/runtime-dom@12447

@vue/server-renderer

pnpm add https://pkg.pr.new/@vue/server-renderer@12447

@vue/shared

pnpm add https://pkg.pr.new/@vue/shared@12447

vue

pnpm add https://pkg.pr.new/vue@12447

@vue/compat

pnpm add https://pkg.pr.new/@vue/compat@12447

commit: 05f5af4

@edison1105
Copy link
Member

Could you please add a test case?

@edison1105 edison1105 added need test The PR has missing test cases. scope: v2 compat labels Nov 21, 2024
@noootwo
Copy link
Contributor Author

noootwo commented Nov 21, 2024

Could you please add a test case?

Ready for review

compatUtils.isCompatEnabled(DeprecationTypes.ATTR_FALSE_VALUE, instance)
) {
compatUtils.warnDeprecation(
compatUtils.softAssertCompatEnabled(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change seems not to be proper.
see 04729ba
see #11126 (comment)

@edison1105 edison1105 added 🍰 p2-nice-to-have Priority 2: this is not breaking anything but nice to have it addressed. wait changes and removed need test The PR has missing test cases. labels Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍰 p2-nice-to-have Priority 2: this is not breaking anything but nice to have it addressed. scope: v2 compat wait changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setting ATTR_ENUMERATED_COERCION compat to false does not disable warning
2 participants