Remove sdkconfig defaults from httpserver example #376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We could also rename it to sdkconfig.defaults.esp32s3, then it should only be picked up for the esp32s3. I think defaults are useful for the S3 in particular, because for best performance you need to select some menuconfig options. |
|
The esp32s3 file already exists (see https://github.com/vroland/epdiy/blob/main/examples/http-server/sdkconfig.defaults.esp32s3). This PR removes only the unnecessary |
|
Ah right, makes sense 😅 |
vroland
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Couldn't figure out why
idf.py buildalways built for ESP32S3 instead of ESP32.Other examples have no default too.