Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add clang-format make targets and CI checks #314

Merged
merged 6 commits into from
May 27, 2024
Merged

Add clang-format make targets and CI checks #314

merged 6 commits into from
May 27, 2024

Conversation

vroland
Copy link
Owner

@vroland vroland commented May 25, 2024

Adds a .clang-format definition and checks in CI to enforce consistent code formatting going forward.

@vroland vroland force-pushed the clang-fmt branch 7 times, most recently from 78a5f0a to 7b136f0 Compare May 25, 2024 12:55
@vroland vroland requested a review from martinberlin May 25, 2024 13:00
@mickeprag
Copy link
Contributor

👍From me! 😎

martinberlin
martinberlin approved these changes May 25, 2024
View reviewed changes
Copy link
Collaborator

@martinberlin martinberlin left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I second Micke!
Looks good for me except for the include ordering because I don’t see the point of it.

@vroland vroland merged commit df2f64d into main May 27, 2024
36 checks passed
@vroland vroland deleted the clang-fmt branch May 27, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schuhumi schuhumi schuhumi left review comments

@martinberlin martinberlin martinberlin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vroland @mickeprag @martinberlin @schuhumi