Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix CKV drift and frame restart in LCD driver #263

Merged
merged 4 commits into from
Nov 16, 2023
Merged

Conversation

vroland
Copy link
Owner

@vroland vroland commented Nov 15, 2023

This PR fixes an issue where the CKV clock would drift for 8 bit screen due to the use of dummy cycles which work around an issue in the ESP32 LCD FIFO. Additionally, dummy cycles are now also used for 16-bit parallel displays, fixing a pixel offset issue.

@vroland
Copy link
Owner Author

vroland commented Nov 15, 2023

@martinberlin If you have the time, can you check if this fixes your issues with the color display?

@martinberlin martinberlin self-requested a review November 15, 2023 18:54
@martinberlin
Copy link
Collaborator

martinberlin commented Nov 15, 2023

Hello Valentin,
I can confirm this works now perfectly with color.
1CB93B66-D40B-43D4-A79A-3D06FE31EB56

For some reason still out of my reach after merging this into s3_color_implementation branch now I need to swap colors. But the colors work correctly without the jump in row 1000. Great fix thanks a lot!
If I remember well that is the right order when you look in the microscope to the color filter (RBG)

-107,13 +107,13 @@ uint8_t epd_get_panel_color(int x, int y, uint8_t r, uint8_t g, uint8_t b) {
     switch (c)
     {
       case 0:
-        return gamme_curve[r]; // R
+        return gamme_curve[g]; // Green
         break;
       case 1:
-        return gamme_curve[b]; // B
+        return gamme_curve[r]; // Red
         break;
       default:
-        return gamme_curve[g];
+        return gamme_curve[b];
     }
 }

@vroland
Copy link
Owner Author

vroland commented Nov 16, 2023

This PR changes also fixes the line start which may shift your color arrangement. But good to hear that it works 👍

@vroland vroland merged commit bd3194a into main Nov 16, 2023
24 checks passed
@vroland vroland deleted the fix-lcd-restart branch May 27, 2024 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants