Enhance acceptance tests #539
Conversation
|
Dear @mfaure, thanks for the PR! This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase? You can find my sourcecode at voxpupuli/vox-pupuli-tasks |
1 similar comment
|
Dear @mfaure, thanks for the PR! This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase? You can find my sourcecode at voxpupuli/vox-pupuli-tasks |
|
@mfaure can you please squash the commits into one? |
|
@bastelfreak Sure! But I still don't know whether acceptance tests are OK or not (waiting for Travis). Locally I get inconsistent errors (errors on PHP 5.6 on 16.04 and error on 18.04) which make me think I don't know how to properly run tests locally. Do you want me to squash whatever the result of Travis? |
|
Sorry, I've just seen Travis is OK. Squashing right now :) |
mfaure
force-pushed
the
enhance-acceptance-tests
branch
from
f6a12d9
to
23df758
Compare
|
@bastelfreak I think it is OK. Feel free to tell me if I missed something! |
mfaure
force-pushed
the
enhance-acceptance-tests
branch
from
23df758
to
9b967f8
Compare
|
@mfaure the diff looks a bit strange and there is a merge conflict. can you please rebase against our latest master branch? (don't merge master into your feature branch) |
mfaure
force-pushed
the
enhance-acceptance-tests
branch
from
9b967f8
to
0632853
Compare
|
@bastelfreak Thanks for your advice! Hope this time is the good one :) |
|
Dear @mfaure, thanks for the PR! This is Vox Pupuli Tasks, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase? You can find my sourcecode at voxpupuli/vox-pupuli-tasks |
Pull Request (PR) description
Enhance acceptance tests
This Pull Request (PR) fixes the following issues
(TODO)