Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix handling for arm64 vs aarch64 on debian/ubuntu apt repositories #1626

Closed
wants to merge 2 commits into from

Conversation

bk-lg
Copy link

@bk-lg bk-lg commented Nov 18, 2024

Pull Request (PR) description

Add logic for using arm64 instead of aarch64 on ubuntu/debian systems.
The system fact reported by puppet is aarch64 but the repositories expecting arm64.

This Pull Request (PR) fixes the following issues

Fixes #1625

@bk-lg
Copy link
Author

bk-lg commented Nov 18, 2024

The CentOS Checks are failing due to ioctl errors.
Seems to be an issue with the pipelines themself or I am interpreting this wrong?

Copy link
Member

@kenyon kenyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be better to have a variable for just the architecture to minimize the amount of repeated code.

@bk-lg
Copy link
Author

bk-lg commented Nov 18, 2024

@kenyon thank you for your fast response. Is this correctly done like you wanted?

@bk-lg
Copy link
Author

bk-lg commented Nov 18, 2024

For notice: Debian 12 check fails due to a timeout of the ci worker against the regular debian archives

@bk-lg bk-lg requested a review from kenyon November 18, 2024 15:43
Copy link
Member

@kenyon kenyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kenyon thank you for your fast response. Is this correctly done like you wanted?

Yes, that's what I was thinking.

@bk-lg
Copy link
Author

bk-lg commented Nov 20, 2024

@kenyon do I need to do anything else for getting this merged or is my worke done here and it will be merged before the next module release or something like that?

@kenyon
Copy link
Member

kenyon commented Nov 20, 2024

What version of puppetlabs-apt are you using? Seems like this should have been fixed in puppetlabs-apt v8.4.0 by puppetlabs/puppetlabs-apt#1012.

@bk-lg
Copy link
Author

bk-lg commented Nov 20, 2024

I am using puppetlabs-apt in version 8.5.0 in the affected environment. But then this seems to be out of scope for the puppet-nginx module and I need to start further investigations and eventualy will file an issue in the puppetlabs-apt project if I find no cause on my side.
Thank you for pointing out this older issue in the apt module.

@bk-lg bk-lg closed this Nov 20, 2024
@bk-lg bk-lg deleted the fix-apt-arm64 branch November 20, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong platform type for ubuntu 22.04 on arm when using nginx repository
2 participants