Fix use of legacy facts #1607
Merged
Fix use of legacy facts #1607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This fixes tests for #1606 for me. |
ekohl
reviewed
Jul 15, 2024
| @@ -2,7 +2,7 @@ | |||
|
|
|||
| Facter.add(:nginx_version) do | |||
| confine { Facter.value(:kernel) != 'windows' } | |||
| confine { Facter.value(:operatingsystem) != 'nexus' } | |||
| confine { Facter.value(:os)['name'] != 'nexus' } | |||
There was a problem hiding this comment.
I think you can use
Suggested change
| confine { Facter.value(:os)['name'] != 'nexus' } | |
| confine { Facter.value('os'.name') != 'nexus' } |
While it's probably safe to assume os is present and there's probably no (measurable) performance difference, but , it's still a good practice to learn.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Replace legacy facts to improve compatibility with Puppet 8.
This Pull Request (PR) fixes the following issues
N/A