Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support Arrays of source/destination IP addresses for nftables::simplerule #252

Merged
merged 1 commit into from
Aug 4, 2024

Conversation

phaedriel
Copy link

@phaedriel phaedriel commented Jul 31, 2024

Pull Request (PR) description

  • Modify type addr : add array IPV4, IPV6 et Addr::Set
  • Modify template simplerule
  • Add many spec tests
  • Generate REFERENCE.md
  • Sort spec tests : group all daddr tests and all saddr tests : IPV4 > IPV4 array > IPV6 > IPV6 array > IPV4 (value @addr) > IPV4 array (value @addr) > IPV6 (value @addr) > IPV6 array (value @addr)

This Pull Request (PR) fixes the following issues

Fixes #223

@phaedriel phaedriel force-pushed the addr_array branch 5 times, most recently from eee9366 to e70beb1 Compare July 31, 2024 09:10
@phaedriel phaedriel marked this pull request as ready for review July 31, 2024 09:16
@phaedriel phaedriel force-pushed the addr_array branch 3 times, most recently from f02a5ad to 5581794 Compare July 31, 2024 09:54
@phaedriel phaedriel changed the title Add support Arrays of source/destination IP addresses for nftables::simplerule DRAFT : Add support Arrays of source/destination IP addresses for nftables::simplerule Jul 31, 2024
@phaedriel phaedriel changed the title DRAFT : Add support Arrays of source/destination IP addresses for nftables::simplerule Add support Arrays of source/destination IP addresses for nftables::simplerule Jul 31, 2024
Copy link
Collaborator

@duritong duritong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - thank you!

@bastelfreak bastelfreak merged commit 8cbcf05 into voxpupuli:master Aug 4, 2024
28 checks passed
@bastelfreak bastelfreak added the enhancement New feature or request label Aug 4, 2024
@phaedriel phaedriel deleted the addr_array branch August 20, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Arrays of source/destination IP addresses for nftables::simplerule
4 participants