Support for cacert_file param on archive resource #422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a cacert_file parameter to the archive type and support for this option in curl, wget and ruby provider. The option could be used to specify a custom CA bundle for certificate verification in the TLS handshake.
Remove empty line.
bastelfreak
approved these changes
Oct 1, 2020
ekohl
reviewed
Jan 23, 2021
ekohl
reviewed
Jan 23, 2021
Fix validation logic for cacert_file. Co-authored-by: Ewoud Kohl van Wijngaarden <[email protected]>
Simplified path to windows ca file. Co-authored-by: Ewoud Kohl van Wijngaarden <[email protected]>
benningm
commented
Jan 29, 2021
ekohl
approved these changes
Jan 29, 2021
|
@alexjfisher any last comments? |
|
If you can confirm that it will not take a half year to review it and then will be reverted again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
This adds a cacert_file parameter to the archive type and
support for this option in curl, wget and ruby provider.
The option could be used to specify a custom CA bundle for
certificate verification in the TLS handshake.
This Pull Request (PR) fixes the following issues
related #400
implements #188
Additional notes
I'm unsure about the part in lib/puppet_x/bodeco/util.rb with ENV['SSL_CERT_FILE'].
Where is it used? Is it still required?