README.md: update dependency packages list #626
Conversation
|
this is a bit like #624 , #621 , #561 |
| libgnutls-dev libsasl2-dev uuid-dev uuid-runtime libtool dh-autoreconf libunistring-dev | ||
| sudo apt-get install build-essential git-core cmake pkg-config subversion libcurl4-dev \ | ||
| gnutls-dev libsasl2-dev uuid-dev uuid-runtime libtool dh-autoreconf libunistring-dev \ | ||
| libjson-c-dev |
There was a problem hiding this comment.
| libjson-c-dev | |
| libjson-c-dev libcurl4-gnutls-dev libssl-dev libunistring-dev |
libcurl4-gnutls-dev and libssl-dev
~/vzlogger $ sudo bash ./install.sh vzlogger libjson libsml mqtt
[...]
-- Looking for json in /usr/local
Json-c search: '/usr/local/include;/usr/local/include;/usr/local/include;/usr/include'
Json-c found: '/usr/local/include'
-- Could NOT find CURL (missing: CURL_LIBRARY CURL_INCLUDE_DIR)
[...]
CMake Error: The following variables are used in this project, but they are set to NOTFOUND.
Please set them or make sure they are set and tested correctly in the CMake files:
CURL_LIBRARY
linked by target "vzlogger" in directory /home/pi/vzlogger/vzlogger/src
OPENSSL_CRYPTO_LIBRARY (ADVANCED)
linked by target "vzlogger" in directory /home/pi/vzlogger/vzlogger/src
OPENSSL_SSL_LIBRARY (ADVANCED)
linked by target "vzlogger" in directory /home/pi/vzlogger/vzlogger/src
-- Configuring incomplete, errors occurred!
See also "/home/pi/vzlogger/vzlogger/build/CMakeFiles/CMakeOutput.log".
See also "/home/pi/vzlogger/vzlogger/build/CMakeFiles/CMakeError.log".
Note
Why are GnuTLS and OpenSSL used? One of them should be enough.
There was a problem hiding this comment.
we have some code that uses openssl directly, you can see this here for example: https://github.com/volkszaehler/vzlogger/pull/530/files
and then there's the ssl library used by curl.
we might benefit from using an openssl-backed libcurl to reduce the memory footprint.
i wonder why you are seeing NOTFOUND there, because there's libcurl4-dev on the list, which should pull in SOME version of libcurl, (and when adding libcurl-*ssl it becomes redundant.)
i was hoping to avoid demanding a specific ssl library for curl here.
(was also wondering how users would deal with maybe ending up with a not-ssl-enabled version of libcurl - if any distro ships such a thing. i think most usage is via http to localhost anyway.)
(i guess you're not seriously proposing to add a second copy of libunistring-dev, and that's just a copy/paste error.)
There was a problem hiding this comment.
the dockerfile only installs curl-dev even...
Line 15 in 15ae6f2
the ci pipeline installs libbcurl4-openssl-dev:
we should really replace this with a reference to either of those, as those can be automatically tested and will not become stale.
There was a problem hiding this comment.
To recap:
I have been compiling vzlogger by having a look on the instructions on the master branch. And during that I installed missing things and noted down what I installed to get things running. Then I recognized that there is already a PR considering updating the dependencies. I tried to merge my changes into the list. Could happen that I duplicated / missed something by manually merging my findings into it. So does not have to be perfect what I noted as a comment.
inspired by @MKesenheimer's #625