Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use synced timestamps for all channels in message #455

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

use synced timestamps for all channels in message #455

wants to merge 5 commits into from

Conversation

r00t-
Copy link
Contributor

@r00t- r00t- commented Mar 11, 2021 •
edited
Loading

fix #426 for D0 meters and SML meters

@r00t- r00t- force-pushed the synced_channel_timestamps branch from fbe23d5 to a79081b Compare March 11, 2021 03:17
@r00t- r00t- mentioned this pull request Mar 11, 2021
Open
@r00t- r00t- changed the title [MeterD0] use synced timestamps for all channels in message use synced timestamps for all channels in message Mar 11, 2021
@r00t- r00t- changed the title use synced timestamps for all channels in message WIP: use synced timestamps for all channels in message Mar 11, 2021
@r00t- r00t- changed the title WIP: use synced timestamps for all channels in message use synced timestamps for all channels in message Mar 14, 2021
@r00t-
Copy link
Contributor Author

r00t- commented Mar 14, 2021 •
edited
Loading

this needs testing by somebody who uses a D0 and/or SML meter

@r00t- r00t- force-pushed the synced_channel_timestamps branch 3 times, most recently from b59df9a to 2d4f19a Compare March 14, 2021 07:03
mbehr1
mbehr1 approved these changes Mar 15, 2021
View reviewed changes
Copy link
Contributor

@mbehr1 mbehr1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx! lgtm.

@r00t-
Copy link
Contributor Author

r00t- commented Mar 15, 2021

@mbehr1:
you think this can be merged?
it's completely untested so far, so i'd rather wait for some feedback.

@mbehr1
Copy link
Contributor

mbehr1 commented Mar 15, 2021

@r00t- well, some test would be good :-)
should(tm) work :-)

@r00t- r00t- force-pushed the synced_channel_timestamps branch 3 times, most recently from 13d374d to 28d5145 Compare March 26, 2021 03:21
@r00t-
Copy link
Contributor Author

r00t- commented Mar 26, 2021

(sorted out some changes that were in the wrong commit(s))

@r00t- r00t- force-pushed the synced_channel_timestamps branch 2 times, most recently from 6c331b9 to 8357283 Compare March 26, 2021 03:27
@r00t-
Copy link
Contributor Author

r00t- commented Mar 26, 2021

is it OK to limit the precision of the timestamp to full seconds? (which the code does)
previously it used the nanosecond precision time of when the specific entry was parsed,
which was kind of useless.
but it it might be useful to have sub-second precision for when the data was received?

@J-A-U
Copy link
Collaborator

J-A-U commented Apr 20, 2022

Still untested?

This was referenced Dec 25, 2023
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbehr1 mbehr1 mbehr1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Assign the same timestamp to measurements from a single transmission
3 participants
@r00t- @mbehr1 @J-A-U