Skip to content
This repository has been archived by the owner on Mar 6, 2024. It is now read-only.

add value check for the vapp.update_product_section. #753

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

devendrapratapsingh
Copy link

@devendrapratapsingh devendrapratapsingh commented Mar 4, 2021

To help us process your pull request efficiently, please include:

• (Required) Short description of changes in the PR topic line
There is an issue to update the product section(guest properties) in the VM using vapp.py

• (Required) Detailed description of changes include tests and
documentation.
Old code was removing the existing property and then append again but without label and other fields.
There is a check required if key is already exist then update the value so that it'll be visible correctly and have the unique set of key in the product section. Old code was created same key multiple times.
detailed messages, refer to those instead

• (Optional) Names of reviewers using @ sign + name


This change is Reviewable

Copy link
Contributor

@rocknes rocknes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @devendrapratapsingh)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants