Skip to content
This repository has been archived by the owner on Mar 6, 2024. It is now read-only.

Support for flex allocation model in org vdc creation #730

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rana-Alotaibi1
Copy link

@rana-Alotaibi1 rana-Alotaibi1 commented Dec 8, 2020

To help us process your pull request efficiently, please include:

  • the changes will allow creating org vdc with flex allocation model and enable the elasticity and memory overhead options

  • is_elastic and include_memory_overhead parameters are added to create_org_vdc


This change is Reviewable

@rana-Alotaibi1 rana-Alotaibi1 changed the title support for flex allocation model in org vdc creation Support for flex allocation model in org vdc creation Dec 8, 2020
@rana-Alotaibi1
Copy link
Author

@rocknes can you plz check this PR

Copy link
Contributor

@rocknes rocknes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @rana-Alotaibi1)


pyvcloud/vcd/org.py, line 1600 at r1 (raw file):

        if is_elastic:
            params.append(E.IsElastic(is_elastic))
        if include_memory_overhead:

Are these params valid for non Flex VDCs?
If user specifies these params and allocation model as say ReservationPool, does VCD throw error?

Also, for FLEX model, if the new params are not sent do they default to False in VCD? Or do we have to still send False to VCD?

Copy link
Contributor

@rocknes rocknes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @rana-Alotaibi1)

@Etibru
Copy link

Etibru commented Apr 22, 2022

Update of the issue?
The projet pyvcloud is end? @rocknes

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants