Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Bump OpenDAL to v0.50.0 #21493

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

chore: Bump OpenDAL to v0.50.0 #21493

wants to merge 3 commits into from

Conversation

Xuanwo
Copy link
Contributor

@Xuanwo Xuanwo commented Oct 12, 2024

This PR will bump opendal to latest v0.50.0 for up to date deps and performance improvement.

@Xuanwo Xuanwo requested a review from a team as a code owner October 12, 2024 06:53
@github-actions github-actions bot added the domain: sinks Anything related to the Vector's sinks label Oct 12, 2024
@jszwedko jszwedko added the no-changelog Changes in this PR do not need user-facing explanations in the release changelog label Oct 12, 2024
jszwedko
jszwedko approved these changes Oct 12, 2024
View reviewed changes
Copy link
Member

@jszwedko jszwedko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Xuanwo !

@jszwedko
Regenerate licenses
4023c35 
Signed-off-by: Jesse Szwedko <[email protected]>
@jszwedko
Copy link
Member

It looks like there were a few compilation errors when you get time.

@Xuanwo
Copy link
Contributor Author

Xuanwo commented Oct 14, 2024

Thank you @jszwedko for the quick review, should have been fixed.

@Xuanwo
Fix build
c22f157 
Signed-off-by: Xuanwo <[email protected]>
auto-merge was automatically disabled October 14, 2024 02:59

Head branch was pushed to by a user without write access

@Xuanwo
Copy link
Contributor Author

Xuanwo commented Oct 16, 2024

Hi,

Neither DATADOG_API_KEY nor DD_API_KEY is in your environment.
Internal Error: API key is missing
    at UploadJUnitXMLCommand.getApiHelper (/usr/local/lib/node_modules/@datadog/datadog-ci/dist/commands/junit/upload.js:197:19)
    at UploadJUnitXMLCommand.<anonymous> (/usr/local/lib/node_modules/@datadog/datadog-ci/dist/commands/junit/upload.js:138:30)
    at Generator.next (<anonymous>)
    at /usr/local/lib/node_modules/@datadog/datadog-ci/dist/commands/junit/upload.js:31:71
    at new Promise (<anonymous>)
    at __awaiter (/usr/local/lib/node_modules/@datadog/datadog-ci/dist/commands/junit/upload.js:27:12)
    at UploadJUnitXMLCommand.execute (/usr/local/lib/node_modules/@datadog/datadog-ci/dist/commands/junit/upload.js:118:16)
    at UploadJUnitXMLCommand.validateAndExecute (/usr/local/lib/node_modules/@datadog/datadog-ci/node_modules/clipanion/lib/advanced/Command.js:73:37)
    at /usr/local/lib/node_modules/@datadog/datadog-ci/node_modules/clipanion/lib/advanced/Cli.js:223:53
    at noopCaptureActivator (/usr/local/lib/node_modules/@datadog/datadog-ci/node_modules/clipanion/lib/advanced/Cli.js:449:12)
+ echo 'Failed to upload results'
Failed to upload results

Seems not related to this PRs change?

@jszwedko
Copy link
Member

Hi,

Neither DATADOG_API_KEY nor DD_API_KEY is in your environment.
Internal Error: API key is missing
    at UploadJUnitXMLCommand.getApiHelper (/usr/local/lib/node_modules/@datadog/datadog-ci/dist/commands/junit/upload.js:197:19)
    at UploadJUnitXMLCommand.<anonymous> (/usr/local/lib/node_modules/@datadog/datadog-ci/dist/commands/junit/upload.js:138:30)
    at Generator.next (<anonymous>)
    at /usr/local/lib/node_modules/@datadog/datadog-ci/dist/commands/junit/upload.js:31:71
    at new Promise (<anonymous>)
    at __awaiter (/usr/local/lib/node_modules/@datadog/datadog-ci/dist/commands/junit/upload.js:27:12)
    at UploadJUnitXMLCommand.execute (/usr/local/lib/node_modules/@datadog/datadog-ci/dist/commands/junit/upload.js:118:16)
    at UploadJUnitXMLCommand.validateAndExecute (/usr/local/lib/node_modules/@datadog/datadog-ci/node_modules/clipanion/lib/advanced/Command.js:73:37)
    at /usr/local/lib/node_modules/@datadog/datadog-ci/node_modules/clipanion/lib/advanced/Cli.js:223:53
    at noopCaptureActivator (/usr/local/lib/node_modules/@datadog/datadog-ci/node_modules/clipanion/lib/advanced/Cli.js:449:12)
+ echo 'Failed to upload results'
Failed to upload results

Seems not related to this PRs change?

Where do you see that? The failure I see is for the webhdfs sink:

2024-10-15T15:24:14.5662119Z thread 'sinks::webhdfs::integration_tests::hdfs_rotate_files_after_the_buffer_size_is_reached' panicked at src/sinks/webhdfs/integration_tests.rs:86:5:
2024-10-15T15:24:14.5663096Z assertion failed: `(left == right)`'
2024-10-15T15:24:14.5663457Z   left: `"4"`
2024-10-15T15:24:14.5663720Z  right: `"3"`
2024-10-15T15:24:14.5663866Z 
2024-10-15T15:24:14.5664026Z Differences (-left|+right):
2024-10-15T15:24:14.5664346Z -4
2024-10-15T15:24:14.5664548Z +3

I know that sink uses OpenDAL so it seems plausibly related.

@jszwedko
Copy link
Member

jszwedko commented Oct 16, 2024 •
edited
Loading

Oh, I see the error you found too. That will just prohibit it from uploading the CI results to Datadog, but isn't actually a CI failure. I think the webhdfs failure is the one that is failing the suite.

@Xuanwo
Copy link
Contributor Author

Xuanwo commented Oct 16, 2024 •
edited
Loading

Oh, I see. I will take a look. Thank you for pointing out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jszwedko jszwedko jszwedko approved these changes

Assignees
No one assigned
Labels
domain: sinks Anything related to the Vector's sinks no-changelog Changes in this PR do not need user-facing explanations in the release changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Xuanwo @jszwedko