Skip to content

Commit

Permalink
remove nodeport from eureka service (istio#1349)
Browse files Browse the repository at this point in the history
Automatic merge from submit-queue

remove nodeport from eureka service

**What this PR does / why we need it**:
Removes `NodePort` designation from Eureka service. This might cause issues with the automated tests if it is not removed. Fortunately, no Eureka tests have been enabled yet, so it shouldn't be causing issues right now.

**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #

**Special notes for your reviewer**:

**Release note**:

```release-note
NONE
```
  • Loading branch information
ijsnellf authored and istio-merge-robot committed Sep 28, 2017
1 parent 6eb0330 commit 057ceb1
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion pilot/test/integration/testdata/eureka.yaml.tmpl
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ spec:
- protocol: TCP
port: 8080
name: http
type: NodePort
---
apiVersion: apps/v1beta1 # for versions before 1.6.0 use extensions/v1beta1
kind: Deployment
Expand Down

0 comments on commit 057ceb1

Please sign in to comment.