chore: [VIO-3019] Update the Dockerfiles #119
Conversation
Update the `Dockerfile`s to use the `debian:stable-slim` as the builder, and `scratch` for the final (production) image.
There was a problem hiding this comment.
I think it is time to move away from COPY synse-emulator-plugin ./plugin. We get away with this because goreleaser ends up pushing the docker image. However it won't make sense for a user if they have to download the whole toolchain on host to compile the binary when we're using a builder for Docker.
Build the go binary statically linked so that it works in the `scratch` image. Runs as the `vaporio` user, instead of root.
This updated PR does two things: builds the go binary statically (the default dynamically linked binary doesn't run inside the Runs the binary as a specific user. That's a new pattern we're adopting across Dockerfiles. |
|
Looks like it's failing with goreleaser. I see now that gorelease is building the binary and then trying to build the Dockerfile, and I'm reading through how we should be structuring the Dockerfile to work with goreleaser. I'll migrate my Dockerfile changes to |
In `dev.Dockerfile`, build the binary inside the Dockerfile build. In `Dockerfile`, follow the goreleaser pattern In `Makefile`, the `docker` target builds the image via gobuilder In `README.md`, add a "build" section to link to the goreleaser install page and document how to build the production image locally.
|
I refactored the Dockerfile(s) a bit. First, I moved the changes I'd made to build the go binary in the docker build to |
|
One last note: it looks like the |
Update the
Dockerfiles to use thedebian:stable-slimas the builder, andscratchfor the final (production) image.Final image size reduced from 14.5MB to 14MB.