Fix race condition between set() and push() #14
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A worker can end up picking up a job between
set()
andpush()
, causing a race condition that results in the job running twice. This PR fixes the race by adding aninitial
state for jobs that haven't yet been pushed.There is no test included because I couldn't work out a clean way to reliably test for the race.
Fixes #13.
Thanks to @sterien7 for reporting, and to @sidepelican for the excellent analysis of the problem in the original bug report against the old version of the driver!