Commits on Jun 11, 2024

1. Fix build warnings treated as errors …

   These warnings prevent builds on latest master with latest stable rustc
   1.78.0 (9b00956e5 2024-04-29)
   
   Full error:
   
      Compiling sonic-server v1.4.8 (/Users/j/src/sonic)
   error: unnecessary qualification
      --> src/store/fst.rs:690:36
       |
   690 | ...                   if std::fs::rename(&bucket_tmp_path, &bucket_final_path).is_ok() {
       |                          ^^^^^^^^^^^^^^^
       |
   note: the lint level is defined here
      --> src/main.rs:8:44
       |
   8   | #![deny(unstable_features, unused_imports, unused_qualifications, clippy::all)]
       |                                            ^^^^^^^^^^^^^^^^^^^^^
   help: remove the unnecessary path segments
       |
   690 -                                 if std::fs::rename(&bucket_tmp_path, &bucket_final_path).is_ok() {
   690 +                                 if fs::rename(&bucket_tmp_path, &bucket_final_path).is_ok() {
       |
   
   warning: trait `StoreGenericKey` is never used
     --> src/store/generic.rs:14:11
      |
   14 | pub trait StoreGenericKey {}
      |           ^^^^^^^^^^^^^^^
      |
      = note: `#[warn(dead_code)]` on by default
   
   warning: `sonic-server` (bin "sonic") generated 1 warning
   error: could not compile `sonic-server` (bin "sonic") due to 1 previous error; 1 warning emitted

   

   jaseemabid committed Jun 11, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for 033c15b
   • Browse repository at this point

   Copy the full SHA

   033c15b View commit details

   Browse the repository at this point in the history