Limited Forwarding (delayed elimination of peers from which message/idontwant is received) #1027
Conversation
…ntwant is received. We delay this action till sendMsg to increase such peers
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## p2p-research #1027 +/- ##
================================================
+ Coverage 83.28% 83.31% +0.02%
================================================
Files 91 91
Lines 15442 15454 +12
================================================
+ Hits 12861 12875 +14
+ Misses 2581 2579 -2
|
| @@ -497,6 +497,9 @@ method rpcHandler*(g: GossipSub, | |||
|
|
|||
| libp2p_gossipsub_duplicate.inc() | |||
|
|
|||
| if msg.data.len > msgId.len * 10: #Dont relay to the peers from which we already received (We just do it for large messages) | |||
| peer.heDontWants[^1].incl(msgId) | |||
There was a problem hiding this comment.
could be renamed to notDesiredMessageIDs or something similar.
| @@ -497,6 +497,9 @@ method rpcHandler*(g: GossipSub, | |||
|
|
|||
| libp2p_gossipsub_duplicate.inc() | |||
|
|
|||
| if msg.data.len > msgId.len * 10: #Dont relay to the peers from which we already received (We just do it for large messages) | |||
There was a problem hiding this comment.
This comment is misleading. Only the "We just do it for large messages" applies to this line.
I'd move the first part one line below.
Also, I'd add the same comment as above:
# IDontWant is only worth it if the message is substantially
# bigger than the messageId
|
this is a good idea - in fact, it should be extended so that it also skips messages that were sent by the other node "in full" while queued. Basically, a peer can tell us they have the message already in two ways: by IDONTWANT and by sending the message in its entirety. The latter is quite possible: because low-prio messages are the ones being forwarded across the network in bursts, it's possible we receive (a duplicate of) it from the peer while sending some other message. |
Remove peers from the relay (ToSendPeers) list, from which message or idontwant is received. We delay this action till sendMsg to increase such peer count.