[NFC] Fix CMakeCache comments. #535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were using the wrong host in the comment for e.g. CA_HOST_TARGET_AARCH64_FEATURES so that depending on configuration, we might document that as controlling RISCV64 features, and giving RISCV64-specific features as an example. - Leave off "e.g. '+v,+zfh'" when the target is not RISC-V. - For cross compilers, use the correct host.
PietroGhg
approved these changes
Sep 25, 2024
coldav
reviewed
Sep 25, 2024
coldav
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
[NFC] Fix CMakeCache comments.
Reason for change
We were using the wrong host in the comment for e.g. CA_HOST_TARGET_AARCH64_FEATURES so that depending on configuration, we might document that as controlling RISCV64 features, and giving RISCV64-specific features as an example.
Description of change
Anything else we should know?
If there's any other relevant information we should know that may help us in
understanding and verifying your patch, please include it here.
Checklist