Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRAFT: Combine aarch64 testing with atomics fix #530

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Commits on Sep 13, 2024

  1. [UnitCL] Fix C11Atomics_73_*, C11Atomics_74_*, C11Atomics_75_*

    These tests test atomic_compare_exchange_weak_explicit which is allowed
    to fail for no clear reason. The test tries to account for this by
    detecting output differences, using that to set a weak_exchange_failed
    boolean, and using that weak_exchange_failed boolean to detect where the
    result of atomic_compare_exchange_weak_explicit does not match
    expectations. That is, in output_reference, it does:
    
              if (value == expected_values[success_index]) {
                weak_exchange_failed = true;
                return true;
              }
    
    Then, bool_output_reference is:
    
            [success_index, weak_exchange_failed](size_t index) {
              return index == success_index && !weak_exchange_failed;
            };
    
    The problem here is that bool_output_reference is constructed capturing
    weak_exchange_failed by value, so it will never pick up the updated
    value even if it was detected that the weak exchange had failed. To fix
    this, capture it by reference instead.
    hvdijk committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    b1f90dc View commit details
    Browse the repository at this point in the history
  2. Add ock workflow for aarch64

    coldav committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    cd3ef85 View commit details
    Browse the repository at this point in the history