Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cl] Permit size 0 in clEnqueue(Read|Write|Copy|Fill)Buffer #387

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[cl] Permit size 0 in clEnqueue(Read|Write|Copy|Fill)Buffer #387

wants to merge 1 commit into from

Commits on Mar 4, 2024

  1. [cl] Permit sizes of 0 in clEnqueueXXXBuffer; mux; HAL 

    This is not explicitly forbidden by the current unified OpenCL
specification for clEnqueueReadBuffer, clEnqueueWriteBuffer, or
clEnqueueCopyBuffer; though it *was* forbidden up to and including
OpenCL 2.0.

Therefore, make the checks for size 0 dependent on the OpenCL version
being built.

A size of zero for clEnqueueFillBuffer has always been valid, so
explicitly test that. The muxCommandFillBuffer function forbids a size
of 0, so it was a bug to call that function when size was 0.

This requires updating the mux specification to allow sizes of 0 in all
of these functions. It also implicitly allows the same in the HAL,
though this is not as tightly specified.
    @frasercrmck
    frasercrmck committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    677b9bb View commit details
    Browse the repository at this point in the history