Remove reference libraries define from config header #584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rbiessy
reviewed
Oct 7, 2024
This reverts commit 8b04c9d.
Instead we can just define them in the CMake for the tests that need it. This is much better because the config header is installed by the default install target, so oneMKL installation would end up with absolute path to the reference libraries.
npmiller
changed the title
mkrainiuk
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
config.hpponeMKL header contains both the macros for which domains are enabled, but it also contains the absolute path to the reference libraries when the tests are built.This is a problem because then when using the
installtarget, this header gets put into the install directory and still contains absolute path to testing infrastructure.This patch splits out the reference libraries path into a separate config header only used by the tests and that won't get installed, that way a oneMKL installation will have a clean config header.
Checklist
All Submissions
Do all unit tests pass locally? Attach a log.
Have you formatted the code using clang-format?