[RAND] rocrand/curand enqueue_native_command impls #579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This implements the dpc++ enqueue_native_command extension that correctly integrates native commands with sycl scheduling. Signed-off-by: JackAKirk <[email protected]>
|
@oneapi-src/onemkl-rng-write could you please review this? Thanks |
Rbiessy
reviewed
Oct 8, 2024
Signed-off-by: JackAKirk <[email protected]>
Signed-off-by: JackAKirk <[email protected]>
Rbiessy
approved these changes
Oct 9, 2024
aelizaro
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the dpc++
enqueue_native_commandextension that correctly integrates native commands with sycl scheduling. Both HIP (rocrand) and CUDA (curand) backends are implemented and tested.See #572 for further details of this extension.
Tests:
test_main_rng_rt_amd.txt
test_main_rng_ct_amd.txt
test_main_rng_ct_nvidia.txt
test_main_rng_rt_nvidia.txt
test_main_rng_ct_nvidia_host_task.txt
test_main_rng_rt_nvidia_host_task.txt
test_main_rng_ct_amd_host_task.txt
test_main_rng_rt_amd_host_task.txt