Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[oneMKL][spblas] Restrict features not supported by any backends #542

Merged
merged 8 commits into from
Sep 6, 2024

Conversation

Rbiessy
Copy link
Contributor

@Rbiessy Rbiessy commented May 27, 2024

Update sparse specification to avoid features that are not supported by Intel oneMKL, cuSPARSE or rocSPARSE.
This is used in oneapi-src/oneMKL#500

  • Do not allow to change the sparse handle types as no backend support it currently.
  • Change the restrictions on matrix view to avoid configurations that are not supported by any backend currently.
  • Simplify constructor of matrix_view as the diagonal view is not useful currently. This could cause confusion.
  • Do not allow spmv conjtrans with symmetric or Hermitian matrices

@Rbiessy
Copy link
Contributor Author

Rbiessy commented Jul 16, 2024

Ping @gajanan-choudhary and @spencerpatty

@Rbiessy
Copy link
Contributor Author

Rbiessy commented Jul 30, 2024

I added one more clarification in 0f57b1c which was needed for the rocSPARSE backend (oneapi-src/oneMKL#544). I think in general it makes sense to specify when should the data be available on the device.

@Rbiessy
Copy link
Contributor Author

Rbiessy commented Aug 26, 2024

Reverted the change fec841e to answer oneapi-src/oneMKL#500 (comment).

Copy link
Contributor

@gajanan-choudhary gajanan-choudhary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gajanan-choudhary gajanan-choudhary merged commit e635a6a into uxlfoundation:main Sep 6, 2024
3 checks passed
@Rbiessy Rbiessy deleted the romain/fix_sparse branch September 6, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants