[oneMKL][RNG] Fixed some bugs for oneMKL RNG device API #525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreyfe1
changed the title
aelizaro
approved these changes
Mar 29, 2024
There was a problem hiding this comment.
Looks good to me, thank you @andreyfe1 for catching this issue!
3 tasks
|
The repo will be moving to https://github.com/uxlfoundation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It doesn't make sense to keep constructors with
std::initializer_listformcg31m1andmcg59generators since oneseedvalue is enough. Due to size of the state formcg31m1uint32_t is enough to store it. Formcg59uint64_t is enough. So, let's keep onlystd::uint32_t seedformcg31m1andstd::uint64_t seedformcg59.Feel free to provide your feedback.